[PATCH] D142839: [AMDGPU] Avoid using tuple where pair does suffice

Mauro Rossi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 11:37:44 PST 2023


maurossi added a comment.

Hi Jay,
here is the output of  'git-clang-format --diff'

  utente at utente-3TB:~/r-x86_kernel/external/llvm-project$ ./clang/tools/clang-format/git-clang-format --diff
  diff --git a/llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp b/llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  index c879b4914ee7..7ee1672049b3 100644
  --- a/llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  +++ b/llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  @@ -5488,9 +5488,9 @@ bool AMDGPUAsmParser::ParseDirectiveHSAMetadata() {
     std::tie(AssemblerDirectiveBegin, AssemblerDirectiveEnd) =
         isHsaAbiVersion3AndAbove(&getSTI())
             ? std::pair(HSAMD::V3::AssemblerDirectiveBegin,
  -                       HSAMD::V3::AssemblerDirectiveEnd)
  +                      HSAMD::V3::AssemblerDirectiveEnd)
             : std::pair(HSAMD::AssemblerDirectiveBegin,
  -                       HSAMD::AssemblerDirectiveEnd);
  +                      HSAMD::AssemblerDirectiveEnd);
   
     if (getSTI().getTargetTriple().getOS() != Triple::AMDHSA) {
       return Error(getLoc(),


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142839/new/

https://reviews.llvm.org/D142839



More information about the llvm-commits mailing list