[PATCH] D143191: DAG: Handle inversion of fcSubnormal | fcZero

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:7333
   // TODO: Try getInvertedFPClassTest
+  bool IsInverted = false;
 
----------------
sepavloff wrote:
> This variable seems unused. It is possible to remove it?
Yes but I was trying to document changes that need to be made to match the DAG version 


================
Comment at: llvm/test/CodeGen/X86/is_fpclass.ll:894-901
+; CHECK-32-NEXT:    flds {{[0-9]+}}(%esp)
+; CHECK-32-NEXT:    fldz
+; CHECK-32-NEXT:    fucompp
+; CHECK-32-NEXT:    fnstsw %ax
+; CHECK-32-NEXT:    # kill: def $ah killed $ah killed $ax
+; CHECK-32-NEXT:    sahf
+; CHECK-32-NEXT:    setp %cl
----------------
sepavloff wrote:
> This code looks incorrect. The argument is compared against 0.0 and the result is true if the comparison is unordered or not equal.
Looks like I broke the inverted case and ended up fixing it in one of my later patches


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143191/new/

https://reviews.llvm.org/D143191