[PATCH] D143358: [RPOFunctionAttrs] Use LazyCallGraph instead of CallGraph

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 10:13:51 PST 2023


aeubanks added a comment.

presubmit testing is saying that `new-pm-lto-defaults.ll` is still failing with the change



================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1918
+  for (LazyCallGraph::RefSCC &RC :
+       llvm::make_early_inc_range(CG.postorder_ref_sccs())) {
+    for (LazyCallGraph::SCC &SCC : RC) {
----------------
don't need `make_early_inc_range`, that's only used when iterating while mutating and we're not mutating the call graph


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143358/new/

https://reviews.llvm.org/D143358



More information about the llvm-commits mailing list