[PATCH] D141848: [Test] Fix YAML mapping keys duplication. NFC.

Mon Feb 6 02:31:41 PST 2023

yota9 accepted this revision.
yota9 added a comment.
This revision is now accepted and ready to land.

BOLT part LGTM

================
Comment at: bolt/test/AArch64/Inputs/plt-gnu-ld.yaml:178
         Addend:          56
+      - Offset:          0x400540
         Symbol:          '__libc_start_main@@GLIBC_2.17'
----------------
asi-sc wrote:
> Currently, YAML parser seems to overwrite Symbol (`.text` -> `'__libc_start_main@@GLIBC_2.17'`)  and Type (`R_AARCH64_ADD_ABS_LO12_NC` -> `R_AARCH64_CALL26`) values at Offset `0x40052C`. And the test works just because we are lucky. I think the right fix is to introduce an offset for `__libc_start_main@@GLIBC_2.17` symbol, but I'm not sure in the offset's value I've chosen. @yota9 , may I ask you to take a quick look at this fix?
Thank you for the fix, yes I think the offset was chosen right

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141848/new/

https://reviews.llvm.org/D141848