[PATCH] D142132: [AArch64] Map DestructiveTernaryCommWithRev intrinsics to pesudo instructions
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 3 08:06:27 PST 2023
sdesmalen added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:660
- defm FMLA_ZPZZZ : sve_fp_3op_p_zds_zx;
- defm FMLS_ZPZZZ : sve_fp_3op_p_zds_zx;
- defm FNMLA_ZPZZZ : sve_fp_3op_p_zds_zx;
- defm FNMLS_ZPZZZ : sve_fp_3op_p_zds_zx;
+ defm FMLA_ZPZZZ : sve_fp_3op_p_zds_zx<int_aarch64_sve_fmla>;
+ defm FMLS_ZPZZZ : sve_fp_3op_p_zds_zx<int_aarch64_sve_fmls>;
----------------
The intrinsics are defined to always merge into the first source operand, so passing this to a pseudo node which assumes the inactive lanes are undef doesn't seem entirely right.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142132/new/
https://reviews.llvm.org/D142132
More information about the llvm-commits
mailing list