[PATCH] D142071: [RISCV] Enable preferZeroCompareBranch to optimize branch on zero in codegenprepare

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 07:50:56 PST 2023


reames added a comment.

Based on your prior comment, I think your regression here comes down to how we lower uadd_with_overflow.  It looks like our lowering of that could use some improvement.

You could investigate improving that and then returning here.  Another option to consider is where we should be returning false from TLI->shouldFormOverflowOp.  (Either case, the result should be a separate patch and this one should then depend on it.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142071/new/

https://reviews.llvm.org/D142071



More information about the llvm-commits mailing list