[PATCH] D141565: [RISCV][CodeGen] Account for LMUL from VS2 for Vector Reduction Instructions

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 07:27:05 PST 2023


michaelmaitland requested changes to this revision.
michaelmaitland added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/RISCV/RISCVScheduleV.td:734
+defm "" : LMULWriteRes<"WriteVFRedOV_From", []>;
+defm "" : LMULWriteRes<"WriteVFWRedV_From", []>;
+defm "" : LMULWriteRes<"WriteVFWRedOV_From", []>;
----------------
michaelmaitland wrote:
> `VFW` prefix should use `LMULWriteResFW` class.
I think we still want `WriteVFWRedV_From` to use `LMULWriteResFW` class since its a floating point widening operation. After that change, it LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141565/new/

https://reviews.llvm.org/D141565



More information about the llvm-commits mailing list