[PATCH] D143167: [NFCI] Cleanup processing of casts in PHITransAddr

[Sergei Kachkov via Phabricator via llvm-commits]

kachkov98 added inline comments.


================
Comment at: llvm/lib/Analysis/PHITransAddr.cpp:189
+      return addAsInput(V);
+    }
 
----------------
mkazantsev wrote:
> I'm fine with `isSafeToSpeculativelyExecute` part, it seems reasonable. But this doesn't seem to be NFC while whole patch claims it's an NFC. Should it be 2 different patches?
I agree, after this change it can fold zext/sext + trunc for example (didn't see any changes on test-suite though).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143167/new/

https://reviews.llvm.org/D143167