[PATCH] D143167: [NFCI] Cleanup processing of casts in PHITransAddr

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 04:13:27 PST 2023


mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/PHITransAddr.cpp:189
+      return addAsInput(V);
+    }
 
----------------
I'm fine with `isSafeToSpeculativelyExecute` part, it seems reasonable. But this doesn't seem to be NFC while whole patch claims it's an NFC. Should it be 2 different patches?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143167/new/

https://reviews.llvm.org/D143167



More information about the llvm-commits mailing list