[PATCH] D143154: [AMDGPU] Introduce divergence and uniform bit fields in tablegen

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 01:52:04 PST 2023


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIDefines.h:137-138
+
+  // Is source of divergence.
+  IsSourceOfDivergence = UINT64_C(1) << 61,
+
----------------
Now would be a good time to adopt the name "IsNeverUniform" instead of "IsSourceOfDivergence", to match the InstructionUniformity enum (https://llvm.org/doxygen/namespacellvm.html#ae58c751054b01f206f9b9e34e461d25f)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143154/new/

https://reviews.llvm.org/D143154



More information about the llvm-commits mailing list