[PATCH] D137670: [PowerPC] Switch to by-name matching for instructions (part 2 of 2).

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 01:16:25 PST 2023


barannikov88 accepted this revision.
barannikov88 added a comment.
This revision is now accepted and ready to land.

LGTM with one note



================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp:242
-    getMachineOpValue(MI, MI.getOperand(OpNo + 1), Fixups, STI) << 34;
-  assert(RegBits == 0 && "Operand must be 0.");
-
----------------
The new version lacks the assertion. Does it make sense to add an `EncoderMethod` to `immZero` just for this?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137670/new/

https://reviews.llvm.org/D137670



More information about the llvm-commits mailing list