[PATCH] D142443: [ORC] Drop Comdat when discarding IR symbol

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 23:35:50 PST 2023


Hahnfeld added a comment.

In D142443#4098212 <https://reviews.llvm.org/D142443#4098212>, @sunho wrote:

> Testcases should trigger a call to discard function since weak symbol gets overridden, right?

Yes, the test triggers exactly this condition. With current `main` and using a build with assertions, you should see the IR verifier complain before code generation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142443/new/

https://reviews.llvm.org/D142443



More information about the llvm-commits mailing list