[PATCH] D142443: [ORC] Drop Comdat when discarding IR symbol

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 17:09:33 PST 2023


sunho added a comment.

Sorry for the delay. I was only looking at the test case; the code change looks reasonable to me. As they are supposed to be discarded anyways, it's safe to just remove COMDAT data as well to make IR valid.

Testcases should trigger a call to discard function since weak symbol gets overridden, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142443/new/

https://reviews.llvm.org/D142443



More information about the llvm-commits mailing list