[PATCH] D142983: Add build for Windows on Arm in packaging script

[Pierrick Bouvier via Phabricator via llvm-commits]

pbo-linaro marked 3 inline comments as done.
pbo-linaro added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:144
   -DPython3_FIND_REGISTRY=NEVER ^
-  -DPACKAGE_VERSION=%package_version% ^
   -DLLDB_RELOCATABLE_PYTHON=1 ^
----------------
hans wrote:
> pbo-linaro wrote:
> > hans wrote:
> > > Why is this being dropped?
> > This adds a regression, as LLD_VERSION is not correctly detected, thus empty.
> > And it fails the cmake step, when a REGEX REPLACE is done on that empty string.
> I think this line has been there for a long time though, so I don't understand how it could regress something. Maybe something else changed?
> I don't think we should drop this, but try to fix the underlying problem.
You are right. After looking more in details, it happens only when PACKAGE_VERSION does not respect "[0-9]+.[0-9]+.*" regex.

Initially, I worked on that script using main branch, which resulted in -DPACKAGE_VERSION=main. 17-init presented the same issue, thus I assumed there had been a regression (and didn't try with 16.0.0-rc1, which works!).

As you can try yourself, this fails at cmake step.
cmake -GNinja  -DLLVM_ENABLE_PROJECTS=lld -DCMAKE_BUILD_TYPE=Release -DPACKAGE_VERSION=main ./llvm
...
-- LLD version: 
CMake Error at .../llvm-project/lld/CMakeLists.txt:137 (string):
  string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
  command.

---

That said, for now, i'll just restore that line in the script, as we expect to build only "normal" releases with this script, matching the expected regex.


================
Comment at: llvm/utils/release/build_llvm_release.bat:377
+cd libxmlbuild
+cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install -DBUILD_SHARED_LIBS=OFF -DLIBXML2_WITH_C14N=OFF -DLIBXML2_WITH_CATALOG=OFF -DLIBXML2_WITH_DEBUG=OFF -DLIBXML2_WITH_DOCB=OFF -DLIBXML2_WITH_FTP=OFF -DLIBXML2_WITH_HTML=OFF -DLIBXML2_WITH_HTTP=OFF -DLIBXML2_WITH_ICONV=OFF -DLIBXML2_WITH_ICU=OFF -DLIBXML2_WITH_ISO8859X=OFF -DLIBXML2_WITH_LEGACY=OFF -DLIBXML2_WITH_LZMA=OFF -DLIBXML2_WITH_MEM_DEBUG=OFF -DLIBXML2_WITH_MODULES=OFF -DLIBXML2_WITH_OUTPUT=ON -DLIBXML2_WITH_PATTERN=OFF -DLIBXML2_WITH_PROGRAMS=OFF -DLIBXML2_WITH_PUSH=OFF -DLIBXML2_WITH_PYTHON=OFF -DLIBXML2_WITH_READER=OFF -DLIBXML2_WITH_REGEXPS=OFF -DLIBXML2_WITH_RUN_DEBUG=OFF -DLIBXML2_WITH_SAX1=OFF -DLIBXML2_WITH_SCHEMAS=OFF -DLIBXML2_WITH_SCHEMATRON=OFF -DLIBXML2_WITH_TESTS=OFF -DLIBXML2_WITH_THREADS=ON -DLIBXML2_WITH_THREAD_ALLOC=OFF -DLIBXML2_WITH_TREE=ON -DLIBXML2_WITH_VALID=OFF -DLIBXML2_WITH_WRITER=OFF -DLIBXML2_WITH_XINCLUDE=OFF -DLIBXML2_WITH_XPATH=OFF -DLIBXML2_WITH_XPTR=OFF -DLIBXML2_WITH_ZLIB=OFF ../../libxml2-v2.9.12 || exit /b 1
+ninja install || exit /b 1
----------------
hans wrote:
> pbo-linaro wrote:
> > hans wrote:
> > > This was probably my fault, but maybe add some newlines while here anyway.
> > I'm not sure to understand what you want me to add exactly here?
> I meant it would be nice to break this very long line into multiple lines (with `^` at the end, like we do with the `set cmake_flags=...` line for example).
Yes sure. I forgot about this long line, as it's wrapped in phabricator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142983/new/

https://reviews.llvm.org/D142983