[PATCH] D142983: Add build for Windows on Arm in packaging script

Wed Feb 1 09:49:54 PST 2023

hans added a comment.

In D142983#4096547 <https://reviews.llvm.org/D142983#4096547>, @pbo-linaro wrote:

> Thanks for your review!
>
> Initially, I duplicated the LIBXML2 build, as you say, with the intent to factorize it later.
> But finally, with @omjavaid , we decided to make both at once, so the result is cleaner.
>
> It's a bit long to test (takes hours to build, and we did it many time), so if we could integrate both, that would be really nice...

Okay.

> For flags and list of targets to build, I'll let @omjavaid answer, as I followed his indications.
>
> We built 17-init and 16.0.0-rc1 with this script, as shown here (arm64 only):
> https://gitlab.com/Linaro/windowsonarm/packages/llvm-release/-/jobs/3694968725
> We build it nightly as well, so we can have an updated llvm for our internal usage.

Great!

================
Comment at: llvm/utils/release/build_llvm_release.bat:144
   -DPython3_FIND_REGISTRY=NEVER ^
-  -DPACKAGE_VERSION=%package_version% ^
   -DLLDB_RELOCATABLE_PYTHON=1 ^
----------------
pbo-linaro wrote:
> hans wrote:
> > Why is this being dropped?
> This adds a regression, as LLD_VERSION is not correctly detected, thus empty.
> And it fails the cmake step, when a REGEX REPLACE is done on that empty string.
I think this line has been there for a long time though, so I don't understand how it could regress something. Maybe something else changed?
I don't think we should drop this, but try to fix the underlying problem.

================
Comment at: llvm/utils/release/build_llvm_release.bat:377
+cd libxmlbuild
+cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install -DBUILD_SHARED_LIBS=OFF -DLIBXML2_WITH_C14N=OFF -DLIBXML2_WITH_CATALOG=OFF -DLIBXML2_WITH_DEBUG=OFF -DLIBXML2_WITH_DOCB=OFF -DLIBXML2_WITH_FTP=OFF -DLIBXML2_WITH_HTML=OFF -DLIBXML2_WITH_HTTP=OFF -DLIBXML2_WITH_ICONV=OFF -DLIBXML2_WITH_ICU=OFF -DLIBXML2_WITH_ISO8859X=OFF -DLIBXML2_WITH_LEGACY=OFF -DLIBXML2_WITH_LZMA=OFF -DLIBXML2_WITH_MEM_DEBUG=OFF -DLIBXML2_WITH_MODULES=OFF -DLIBXML2_WITH_OUTPUT=ON -DLIBXML2_WITH_PATTERN=OFF -DLIBXML2_WITH_PROGRAMS=OFF -DLIBXML2_WITH_PUSH=OFF -DLIBXML2_WITH_PYTHON=OFF -DLIBXML2_WITH_READER=OFF -DLIBXML2_WITH_REGEXPS=OFF -DLIBXML2_WITH_RUN_DEBUG=OFF -DLIBXML2_WITH_SAX1=OFF -DLIBXML2_WITH_SCHEMAS=OFF -DLIBXML2_WITH_SCHEMATRON=OFF -DLIBXML2_WITH_TESTS=OFF -DLIBXML2_WITH_THREADS=ON -DLIBXML2_WITH_THREAD_ALLOC=OFF -DLIBXML2_WITH_TREE=ON -DLIBXML2_WITH_VALID=OFF -DLIBXML2_WITH_WRITER=OFF -DLIBXML2_WITH_XINCLUDE=OFF -DLIBXML2_WITH_XPATH=OFF -DLIBXML2_WITH_XPTR=OFF -DLIBXML2_WITH_ZLIB=OFF ../../libxml2-v2.9.12 || exit /b 1
+ninja install || exit /b 1
----------------
pbo-linaro wrote:
> hans wrote:
> > This was probably my fault, but maybe add some newlines while here anyway.
> I'm not sure to understand what you want me to add exactly here?
I meant it would be nice to break this very long line into multiple lines (with `^` at the end, like we do with the `set cmake_flags=...` line for example).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142983/new/

https://reviews.llvm.org/D142983