[PATCH] D143090: [LegalizeTypes] Tail call libcalls where possible

[Luke Lau via Phabricator via llvm-commits]

luke added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp:208
-  // changes of the root.
-  HandleSDNode Dummy(DAG.getRoot());
-  Dummy.setNodeId(Unanalyzed);
----------------
luke wrote:
> I removed the handle here because it prevents the root node from being delete-able (DeleteNode throws an assertion complaining that it's still in use by the handle)
It didn't seem to affect any test cases but I'm not sure what I'm missing... I'd love to know if there's another way around this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143090/new/

https://reviews.llvm.org/D143090