[PATCH] D143090: [LegalizeTypes] Tail call libcalls where possible

[Luke Lau via Phabricator via llvm-commits]

luke added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp:208
-  // changes of the root.
-  HandleSDNode Dummy(DAG.getRoot());
-  Dummy.setNodeId(Unanalyzed);
----------------
I removed the handle here because it prevents the root node from being delete-able (DeleteNode throws an assertion complaining that it's still in use by the handle)


================
Comment at: llvm/test/CodeGen/RISCV/libcall-tail-calls.ll:237-244
+; RV32-ALL-LABEL: sin_f32:
+; RV32-ALL:       # %bb.0:
+; RV32-ALL-NEXT:    tail sinf at plt
+;
 ; F-ABI-ALL-LABEL: sin_f32:
 ; F-ABI-ALL:       # %bb.0:
 ; F-ABI-ALL-NEXT:    tail sinf at plt
----------------
This test fails because the checks generated by update_llc_checks.py seem overlap


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143090/new/

https://reviews.llvm.org/D143090