[PATCH] D142998: [SVE][codegen] Add test case for a fused multiply-add (NFC)

[Sushant Gokhale via Phabricator via llvm-commits]

sushgokh added a comment.

In D142998#4095821 <https://reviews.llvm.org/D142998#4095821>, @SjoerdMeijer wrote:

> I think we need at least 3 patches:
>
> 1. Instruction selection of `mad` for pattern `add ( mul, splat_vector(C))`. That is D142656 <https://reviews.llvm.org/D142656>.
> 2. New tests for this `mad` pattern and isel. That is this patch, D142998 <https://reviews.llvm.org/D142998>.
>
> So the above only deals with `mad`, and not with any mla -> mad changes. That's why I suggested to strip out any mla changes out of patches 1 and 2. If you want to make changes in this area, we will follow the same approach:
>
> 3. Create a patch to precommit new test, if applicable.
> 4. Create a patch that implements these mla -> mad changes.
>
> What do you think, makes sense?

I tried seperating (1,2) and (3,4) as you say above. However, mla->mad is side effect of implementing (1) and this makes seperating (1) and (4) a difficult thing unless we introduce some hacks to do so


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142998/new/

https://reviews.llvm.org/D142998