[PATCH] D142998: [SVE][codegen] Add test case for a fused multiply-add (NFC)
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 1 01:00:36 PST 2023
SjoerdMeijer added a comment.
I think we need at least 3 patches:
1. Instruction selection of `mad` for pattern `add ( mul, splat_vector(C))`. That is D142656 <https://reviews.llvm.org/D142656>.
2. New tests for this `mad` pattern and isel. That is this patch, D142998 <https://reviews.llvm.org/D142998>.
So the above only deals with `mad`, and not with any mla -> mad changes. That's why I suggested to strip out any mla changes out of patches 1 and 2. If you want to make changes in this area, we will follow the same approach:
3. Create a patch to precommit new test, if applicable.
4. Create a patch that implements these mla -> mad changes.
What do you think, makes sense?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142998/new/
https://reviews.llvm.org/D142998
More information about the llvm-commits
mailing list