[PATCH] D141848: [Test] Fix YAML mapping keys duplication. NFC.

[Anton Sidorenko via Phabricator via llvm-commits]

asi-sc added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/strip-all-gnu.test:28-29
   - Name:            .symtab.dyn
-    Type:            SHT_SYMTAB
-    Flags:           [ SHF_ALLOC ]
     Type:            SHT_NOBITS
+    Flags:           [ SHF_ALLOC ]
   - Name:            .text
----------------
jhenderson wrote:
> I don't think this is a correct change, based on my memory of this test and the --strip-all-gnu behaviour. I think it's likely the second Type key is actually spurious and should be deleted.
@jhenderson , thanks for your suggestion. However, if I remove the second Type key, llvm-objcopy reports an error: 

```
llvm-objcopy: error: 'build-release/test/tools/llvm-objcopy/ELF/Output/strip-all-gnu.test.tmp': string table '.strtab' cannot be removed because it is referenced by the symbol table '.symtab.dyn'
```

Do you have any ideas what might be wrong?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141848/new/

https://reviews.llvm.org/D141848