[PATCH] D141848: [Test] Fix YAML mapping keys duplication. NFC.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 31 01:02:34 PST 2023
jhenderson added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/strip-all-gnu.test:28-29
- Name: .symtab.dyn
- Type: SHT_SYMTAB
- Flags: [ SHF_ALLOC ]
Type: SHT_NOBITS
+ Flags: [ SHF_ALLOC ]
- Name: .text
----------------
I don't think this is a correct change, based on my memory of this test and the --strip-all-gnu behaviour. I think it's likely the second Type key is actually spurious and should be deleted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141848/new/
https://reviews.llvm.org/D141848
More information about the llvm-commits
mailing list