[PATCH] D142959: [RISCV] Handle FRMArg as an optional operand instead of using InstAliases.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D142959#4095481 <https://reviews.llvm.org/D142959#4095481>, @joshua-arch1 wrote:

>   void RISCVInstPrinter::printFRMArg(const MCInst *MI, unsigned OpNo,
>                                      const MCSubtargetInfo &STI, raw_ostream &O) {
>     auto FRMArg =
>         static_cast<RISCVFPRndMode::RoundingMode>(MI->getOperand(OpNo).getImm());
>     if (PrintAliases && !NoAliases && FRMArg == RISCVFPRndMode::RoundingMode::DYN)
>       return;
>     O << ", " << RISCVFPRndMode::roundingModeToString(FRMArg);
>   }
>
> In printFRMArg(), there is an extra "," before the FRM output.  Why?
> e.g. I get fcvtmod.w.d a1, ft1, , rtz for the MC output.

Need to remove the comma from the AsmString on the instruction as I did in this patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142959/new/

https://reviews.llvm.org/D142959