[PATCH] D142959: [RISCV] Handle FRMArg as an optional operand instead of using InstAliases.

Jun Sha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 19:26:23 PST 2023


joshua-arch1 added a comment.

  void RISCVInstPrinter::printFRMArg(const MCInst *MI, unsigned OpNo,
                                     const MCSubtargetInfo &STI, raw_ostream &O) {
    auto FRMArg =
        static_cast<RISCVFPRndMode::RoundingMode>(MI->getOperand(OpNo).getImm());
    if (PrintAliases && !NoAliases && FRMArg == RISCVFPRndMode::RoundingMode::DYN)
      return;
    O << ", " << RISCVFPRndMode::roundingModeToString(FRMArg);
  }

In printFRMArg(), there is an extra "," before the FRM output.  
e.g. I get fcvtmod.w.d a1, ft1, , rtz for the MC output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142959/new/

https://reviews.llvm.org/D142959



More information about the llvm-commits mailing list