[PATCH] D142090: [InstCombine] precommit tests for D140666
chenglin.bi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 31 19:10:44 PST 2023
bcl5980 added a comment.
I'm not sure if you should add negative tests for
(~B & C) == 0 && (~D & E) == 0,
But we may need some more negative tests. At least one more for
!ConstB->isSubsetOf(*ConstD) && !ConstD->isSubsetOf(*ConstB)
It's better you can try more different constants in the different tests.
And we need at least 1 vector test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142090/new/
https://reviews.llvm.org/D142090
More information about the llvm-commits
mailing list