[PATCH] D142874: [LoongArch] Implement TargetLowering::isLegalAddressingMode() hook
Gong LingQin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 31 18:19:15 PST 2023
gonglingqin added inline comments.
================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:3120-3122
+ // 3. reg + 14-bit signed offset (The memory access address calculation
+ // method is to logical left shift the 14-bit immediate data si14 by
+ // 2 bits, sign extension, and then sum the value in the register.)
----------------
xen0n wrote:
> nit: "reg + 14-bit signed offset left-shifted by 2" could be a lot more concise.
Thanks! I will modify it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142874/new/
https://reviews.llvm.org/D142874
More information about the llvm-commits
mailing list