[PATCH] D142874: [LoongArch] Implement TargetLowering::isLegalAddressingMode() hook

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n accepted this revision.
xen0n added a comment.
This revision is now accepted and ready to land.

LGTM with the nit addressed, thanks!



================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:3120-3122
+  //  3. reg + 14-bit signed offset (The memory access address calculation
+  //     method is to logical left shift the 14-bit immediate data si14 by
+  //     2 bits, sign extension, and then sum the value in the register.)
----------------
nit: "reg + 14-bit signed offset left-shifted by 2" could be a lot more concise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142874/new/

https://reviews.llvm.org/D142874