[PATCH] D142940: [llvm][SelectionDAGBuilder] change callbr.landingpad intrinsic to accept explicit param

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 15:39:41 PST 2023


nickdesaulniers created this revision.
Herald added subscribers: pengfei, hiraditya.
Herald added a project: All.
nickdesaulniers requested review of this revision.
Herald added subscribers: llvm-commits, jdoerfert.
Herald added a project: LLVM.

This simplifies code in SelectionDAGBuilder. Originally, this intrinsic
was designed to have an implicit operand, based on
https://gist.github.com/nickdesaulniers/6df8e1a15f23636e2bf8abec96d425c7.

Turns out, codegen is simpler to just have an explicit parameter. Make
what was the implicit corresponding CallBrInst explicit and simplify
codegen.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142940

Files:
  llvm/include/llvm/IR/Intrinsics.td
  llvm/lib/CodeGen/CallBrPrepare.cpp
  llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/test/CodeGen/AArch64/callbr-asm-outputs-indirect-isel.ll
  llvm/test/CodeGen/AArch64/callbr-prepare.ll
  llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel.ll
  llvm/test/Transforms/SimplifyCFG/callbr-destinations.ll
  llvm/test/Verifier/callbr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142940.493440.patch
Type: text/x-patch
Size: 24125 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230130/28f1409d/attachment.bin>


More information about the llvm-commits mailing list