[PATCH] D142911: [RISCV] Tailcall some more libcalls on soft-float ABIs

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 10:05:46 PST 2023


luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:13271
+
+  if (!(Copy->getOpcode() == ISD::CopyToReg)) {
     return false;
----------------
reames wrote:
> The comparison here is non-idiomatic.   Use != instead.
Whoops, this was left in from an earlier version, will remove


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142911/new/

https://reviews.llvm.org/D142911



More information about the llvm-commits mailing list