[PATCH] D142911: [RISCV] Tailcall some more libcalls on soft-float ABIs

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Can you update the review description to be more specific?  The current text sounds like you're adding new libcalls, but you're really just peeking through a bitcast.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:13266
   SDNode *Copy = *N->use_begin();
   // TODO: Handle additional opcodes in order to support tail-calling libcalls
   // with soft float ABIs.
----------------
Move the bitcast check above the comment please?


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:13271
+
+  if (!(Copy->getOpcode() == ISD::CopyToReg)) {
     return false;
----------------
The comparison here is non-idiomatic.   Use != instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142911/new/

https://reviews.llvm.org/D142911