[PATCH] D140242: [AMDGPU] Modify adjustInliningThreshold to also consider the cost of passing function arguments through the stack

[Janek van Oirschot via Phabricator via llvm-commits]

JanekvO marked an inline comment as done.
JanekvO added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:1193-1194
+  for (const Argument &A : Callee->args()) {
+    MVT ArgType = MVT::getVT(A.getType());
+    if (A.getType()->isPointerTy()) {
+      ArgType =
----------------
arsenm wrote:
> Can you just go through EVT? This is going to not work for vectors of pointers. You shouldn't have to consider any of these details
> This is going to not work for vectors of pointers.
Sorry, is there a way to get vector of pointers working with EVT that I'm missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140242/new/

https://reviews.llvm.org/D140242