[PATCH] D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 03:57:18 PST 2023


lkail added inline comments.


================
Comment at: llvm/test/Object/archive-big-read-empty-with-freelist.test:3
+# RUN: llvm-ar tv %p/Inputs/aix-empty-big-archive-with-freelist.a 2>&1 \
+# RUN:   | not grep 'truncated or malformed archive'
----------------
jhenderson wrote:
> This test will pass spuriously if the error message is ever updated, which is certainly not impossible. Is the output completely empty, or is there some other output you could check and then show that nothing else is present?
Thanks for pointing it out. The output is indeed empty. I've posted https://reviews.llvm.org/D142883 to address your comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138986/new/

https://reviews.llvm.org/D138986



More information about the llvm-commits mailing list