[PATCH] D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

@lkail, please could you update the tests as directed inline. We don't use `grep` in new tests, and use `FileCheck` instead. There are plenty of examples in existing tests of how to use FileCheck. Also, I always recommend that test comments (as opposed to lit directives) should use `##` rather than just `#`.

Please either revert and update the tests, or create a new patch to update the tests as suggested.



================
Comment at: llvm/test/Object/archive-big-malformed-first-member.test:4
+# RUN: echo -n "0                   0                   0                   128                 0                   0                   " >> %t.a
+# RUN: not llvm-ar tv %t.a 2>&1 | grep 'truncated or malformed archive'
+# RUN: echo    "<bigaf>" > %t.a
----------------
`grep` is deprecated in testing. Please use `FileCheck` instead. Please update these tests to not use `grep`.


================
Comment at: llvm/test/Object/archive-big-read-empty-with-freelist.test:3
+# RUN: llvm-ar tv %p/Inputs/aix-empty-big-archive-with-freelist.a 2>&1 \
+# RUN:   | not grep 'truncated or malformed archive'
----------------
This test will pass spuriously if the error message is ever updated, which is certainly not impossible. Is the output completely empty, or is there some other output you could check and then show that nothing else is present?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138986/new/

https://reviews.llvm.org/D138986