[PATCH] D142445: [mlir][tensor|memref] Harden the checks on dim op

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

> The shape dialect has a special type to model a "shape" and this type has an invalid state: https://mlir.llvm.org/docs/Dialects/ShapeDialect/#shapetype

Thanks!

I don't see how it is used though. Meaning, I don't see any actual implementation using/supporting that.

E.g., in the shape-to-standard conversion pass I see that pretty much all operations have something resembling:

  // For now, only error-free types are supported by this lowering.
  if (op.getType().isa<xxxType>())
    return failure();

I don't see any test with an `invalid` input or an `invalid` output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142445/new/

https://reviews.llvm.org/D142445