[PATCH] D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 30 02:21:19 PST 2023
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:321-322
+ // The relocation encodes the bit length being relocated minus 1. Add
+ // back
+ // the 1 to get the actual length being relocated.
+ return (Info & XCOFF::XR_BIASED_LENGTH_MASK) + 1;
----------------
Nit: this word wrapping wasn't fixed when the code was moved. Please make an NFC commit (no review needed) to fix it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136787/new/
https://reviews.llvm.org/D136787
More information about the llvm-commits
mailing list