[PATCH] D142787: [GVN] Don't count debug instructions when limit the number of checked instructions
Jeremy Morse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 30 01:14:34 PST 2023
jmorse added a comment.
>From a debug-info perspective this LGTM, with the test improvement to reduce the size -- I'm not familiar with all of GVN though. The objective of ensuring that debug-info can't affect the code generated is an important one.
You might consider using the `BasicBlock::instructionsWithoutDebug` range to iterate over instructions without any explicit logic to deal with debug-info and pseudo instructions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142787/new/
https://reviews.llvm.org/D142787
More information about the llvm-commits
mailing list