[PATCH] D142621: [Couroutines] Modify CoroFrame materializable into a callback

[Jannik Silvanus via Phabricator via llvm-commits]

jsilvanus accepted this revision.
jsilvanus added a comment.

LGTM, one minor inline comment.



================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:1935
+               TargetTransformInfo &TTI, bool OptimizeFrame,
+               std::function<bool(Instruction &)> MaterializableCallback) {
   PrettyStackTraceFunction prettyStackTrace(F);
----------------
Maybe pass the callback by reference, both here and for the following calls? 

An `std::function` is quite large (32 bytes for libstdc++, 40 for MSVC, 48 for libc++).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142621/new/

https://reviews.llvm.org/D142621