[PATCH] D141653: [X86] Improve instruction ordering of constant `srl/shl` with `and` to get better and-masks

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n marked 6 inline comments as done.
goldstein.w.n added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:4013-4015
+  /// @param Shift1 outer shift Node
+  /// @param Op to combine shifts across
+  /// @param Shift2 inner shift Node
----------------
pengfei wrote:
> Is `Shift1` inner and `Shift2` outer?
> Is `Shift1` inner and `Shift2` outer?

Yes, renamed to `OuterShift` and `InnerShift` to be clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141653/new/

https://reviews.llvm.org/D141653