[PATCH] D142847: [InstCombine] reduce icmp_eq0-of-and-of-select-of-constants

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:1901
+    Value *A, *B, *TVal, *FVal;
+    if (match(X, m_Select(m_Value(A), m_Value(TVal), m_Value(FVal))) &&
+        match(Y, m_Select(m_Value(B), m_Specific(TVal), m_Specific(FVal)))) {
----------------
goldstein.w.n wrote:
> Can this just be `match(X, m_Select(m_Value(A), m_APInt(TC), m_APInt(FC))` and the `m_SpecificInt` in the match on `Y`?
Sure - I was actually backtracking from the more general patch in this version, but I can adjust that to be the more direct matcher.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142847/new/

https://reviews.llvm.org/D142847