[PATCH] D142797: [X86] Make `prefetchit{0/1}` emit an assembler warning if the operand is not rip-rel

Sat Jan 28 23:48:56 PST 2023

goldstein.w.n added a comment.

In D142797#4088587 <https://reviews.llvm.org/D142797#4088587>, @craig.topper wrote:

> In D142797#4088584 <https://reviews.llvm.org/D142797#4088584>, @goldstein.w.n wrote:
>
>> In D142797#4088581 <https://reviews.llvm.org/D142797#4088581>, @craig.topper wrote:
>>
>>> Why not do this in X86AsmParser::validateInstruction?
>>
>> AFAICT it only throws compilation errors.
>
> I believe the uses of `Warning` in `validateInstruction` actually return `false` so they don't stop the parsing.

Oh, I'm sorry I misread your earlier comment and thought you where referring to `X86InstrInfo::verifyInstruction`.

Yeah `X86AsmParser::validateInstruction` seems to make sense, will give it a shot for V3.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142797/new/

https://reviews.llvm.org/D142797