[PATCH] D142797: [X86] Make `prefetchit{0/1}` emit an assembler warning if the operand is not rip-rel

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D142797#4088584 <https://reviews.llvm.org/D142797#4088584>, @goldstein.w.n wrote:

> In D142797#4088581 <https://reviews.llvm.org/D142797#4088581>, @craig.topper wrote:
>
>> Why not do this in X86AsmParser::validateInstruction?
>
> AFAICT it only throws compilation errors.

I believe the uses of `Warning` in `validateInstruction` actually return `false` so they don't stop the parsing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142797/new/

https://reviews.llvm.org/D142797