[PATCH] D141875: [InstCombine] Reorder (shl (add/sub (shl x, C0), y), C1) -> (add/sub (shl x, C0 + C1), (shl y, C1))

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 18:16:06 PST 2023


spatel added a comment.

In D141875#4087663 <https://reviews.llvm.org/D141875#4087663>, @goldstein.w.n wrote:

> Yeah, also unable to reproduce locally. Coming to conclusion its unrelated, cest la vie.
> For recommit should I just apply re-apply the patches and prefix with "Recommit"/explain it was a false positive?

That should be fine - I usually just append a "(2nd try)" on the patch title, add a short explanation statement, then the original commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141875/new/

https://reviews.llvm.org/D141875



More information about the llvm-commits mailing list