[PATCH] D141875: [InstCombine] Reorder (shl (add/sub (shl x, C0), y), C1) -> (add/sub (shl x, C0 + C1), (shl y, C1))

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 17:30:31 PST 2023


goldstein.w.n added a comment.

In D141875#4087655 <https://reviews.llvm.org/D141875#4087655>, @spatel wrote:

> In D141875#4087595 <https://reviews.llvm.org/D141875#4087595>, @goldstein.w.n wrote:
>
>> Either this or `D140850` cause the failure: https://lab.llvm.org/buildbot/#/builders/183/builds/10447
>>
>> Going to revert while I look into it.
>
> If that was the only builder that failed, I'd try again. It passed on the next try (before you reverted!):
> https://lab.llvm.org/buildbot/#/builders/183
> Sometimes buildbots just fail inexplicably. :)

Yeah, also unable to reproduce locally. Coming to conclusion its unrelated, cest la vie.
For recommit should I just apply re-apply the patches and prefix with "Recommit"/explain it was a false positive?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141875/new/

https://reviews.llvm.org/D141875



More information about the llvm-commits mailing list