[PATCH] D142446: [MC] Disable copying and moving of MCInstrDescs the C++20 way

Fri Jan 27 09:25:16 PST 2023

dblaikie added a comment.

In D142446#4085389 <https://reviews.llvm.org/D142446#4085389>, @foad wrote:

> In D142446#4081425 <https://reviews.llvm.org/D142446#4081425>, @dblaikie wrote:
>
>> Sounds OK to me, but yeah, might be overkill.
>>
>> @foad any sense of how important this is? whether it's worth the above compelxity?
>
> I don't think it's critical to have this checking, it's just nice to have. Personally I would be fine with a C++20-only solution (under an appropriate `#if`), and live without the checking until we adopt C++20. (And even before that we would get some checking from the C++20 builders.)

Given the relatively small adoption of C++20 just yet, I'd hesitate to put more burden on those maintaining/working towards C++20 support to cleanup failures that aren't the minimum necessary for C++20 support - if it's not validated by a more mainstream configuration, I think it's best not to test it only in C++20 mode.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142446/new/

https://reviews.llvm.org/D142446