[PATCH] D142446: [MC] Disable copying and moving of MCInstrDescs the C++20 way

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 05:46:00 PST 2023


foad added a comment.

In D142446#4081425 <https://reviews.llvm.org/D142446#4081425>, @dblaikie wrote:

> Sounds OK to me, but yeah, might be overkill.
>
> @foad any sense of how important this is? whether it's worth the above compelxity?

I don't think it's critical to have this checking, it's just nice to have. Personally I would be fine with a C++20-only solution (under an appropriate `#if`), and live without the checking until we adopt C++20. (And even before that we would get some checking from the C++20 builders.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142446/new/

https://reviews.llvm.org/D142446



More information about the llvm-commits mailing list