[PATCH] D140457: [BOLT] Process fragment siblings in lite mode, keep lite mode on

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 14:12:13 PST 2023


Amir marked an inline comment as done.
Amir added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:504
+    // Check if BF is a fragment of TargetBF or vice versa.
+    return (BF.isFragment() && BF.isParentFragment(TargetBF)) ||
+           (TargetBF->isFragment() && TargetBF->isParentFragment(&BF));
----------------
maksfb wrote:
> Do we have to check `isFragment()` before checking `isParentFragment()`? BTW, what do you think about renaming the latter to `isChildOf()`?
D142667


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140457/new/

https://reviews.llvm.org/D140457



More information about the llvm-commits mailing list