[PATCH] D140457: [BOLT] Process fragment siblings in lite mode, keep lite mode on

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 14:07:38 PST 2023


Amir added a comment.

In D140457#4064034 <https://reviews.llvm.org/D140457#4064034>, @maksfb wrote:

> Thanks for refactoring the code.
>
> What happens to stripped binaries? Should we disable lite mode for them?

Actually, I don't know what happens to stripped binaries. For them, the more functions we process, the higher the risk that we miss a fragment or incorrectly update the jump table. Disabling lite mode doesn't fix processing stripped binaries with split functions. BTW, lite mode wasn't even disabled for such binaries since the determination is based on symbol names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140457/new/

https://reviews.llvm.org/D140457



More information about the llvm-commits mailing list