[PATCH] D142519: [KnownBits] Add blsi and blsmsk

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. I'd suggest adding a description of what the operation is supposed to do in the comment, for those not familiar with bmi instructions.



================
Comment at: llvm/include/llvm/Support/KnownBits.h:425
 
+  /// Compute known bits for X & -X. The name comes from the X86 BMI instruction
+  /// BLSI.
----------------



================
Comment at: llvm/include/llvm/Support/KnownBits.h:429
+
+  /// Compute known bits for X ^ (X - 1).
+  KnownBits blsmsk() const;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142519/new/

https://reviews.llvm.org/D142519