[PATCH] D142519: [KnownBits] Add blsi and blsmsk

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 12:16:58 PST 2023


goldstein.w.n added a comment.

In D142519#4080713 <https://reviews.llvm.org/D142519#4080713>, @foad wrote:

> Things that are implemented should be tested. Things that aren't implemented shouldn't have the prototypes. (Of course you can //design// the full API now, but don't put the unimplemented parts in a patch and expect to commit it.)

Okay, fair enough. Reverted back to you're code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142519/new/

https://reviews.llvm.org/D142519



More information about the llvm-commits mailing list