[PATCH] D142409: [RISCV][InsertVSETVLI] Handle partially transparent instructions in PRE

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 07:21:58 PST 2023


reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1201
+  VSETVLIInfo CurInfo = AvailableInfo;
+  int64_t TransitionsRemoved = 0;
+  for (const MachineInstr &MI : MBB) {
----------------
craig.topper wrote:
> Why int64_t as opposed to int?
What's the largest number of instructions a basic block can hold?  Is it bounded by an i31?  It probably is in all practical term, but int64_t felt "safer".  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142409/new/

https://reviews.llvm.org/D142409



More information about the llvm-commits mailing list