[PATCH] D142516: [SVE] Move isel for casting between NEON and SVE vector types into tablegen.

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 01:00:25 PST 2023


c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.

Couple of minor nits but otherwise LGTM



================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:14
+// Helper class to find the largest legal scalable vector type that can hold VT.
+// Non-macthes return VT, which often means VT is the container type.
+class SVEContainerVT<ValueType VT> {
----------------
nit: matches


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:40
+    !eq(VT, nxv4bf16): nxv8bf16,
+    1 : VT);
+}
----------------
nit: true


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142516/new/

https://reviews.llvm.org/D142516



More information about the llvm-commits mailing list